New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧 Fix failing main #75

Merged

janjakubnanista merged 4 commits into main from fix-main

Dec 8, 2023

Contributor

janjakubnanista commented Dec 7, 2023 •

edited

Loading

In this PR

Remove unnecessary hardhat-deploy-ethers, the ethers versions collide. We cannot yet update to ethers@6 because hardhat-deploy depends on zksync-web3 which internally depends on ethers@5 and will fail to compile

janjakubnanista added 4 commits

December 7, 2023 13:55


          fix: Fix failing main

930bbed

WIP

31fba9c


          fix: Don't use hardhat-ethers in tests, the ethers versions conflict

f0378f5


          chore: Drop hardhat-deploy-ethers

193e2b4

janjakubnanista requested review from sirarthurmoney and 0xIryna

December 8, 2023 00:15

0xIryna approved these changes

View reviewed changes

janjakubnanista merged commit 4a4a62f into main

1 check passed

janjakubnanista deleted the fix-main branch

December 8, 2023 00:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet